Re: Enums patch v2

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Dunstan <pgsql(at)tomd(dot)cc>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Enums patch v2
Date: 2007-02-02 03:50:12
Message-ID: 200702020350.l123oCx13234@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Where are we on this?

---------------------------------------------------------------------------

Tom Dunstan wrote:
> Hi all
>
> Here is an updated version of the enums patch. It has been brought up to
> date and applies against current CVS HEAD. The original email is at [1],
> and describes the implementation.
>
> This version contains sgml documentation, and contains the missing
> bounds checks and error codes noted in the last email.
>
> As mentioned before, the only part that I'm not super keen on is the
> hack required to pass the type oid in to the text-to-enum cast function,
> since normally those take type mods but not type oids. I wasn't sure how
> else to get a cast working though, short of allowing another type of
> cast function which accepts type oids as well. That seemed overkill for
> just one case, though, and was getting a bit beyond the realms of what I
> wanted to get done with this patch.
>
> Anyway, it's reasonably feature complete and should be appropriately
> documented now, so feedback gratefully accepted.
>
> Cheers
>
> Tom
>
> [1] http://archives.postgresql.org/pgsql-patches/2006-09/msg00000.php

[ application/x-gzip is not supported, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2007-02-02 04:04:58 Re: Archive log compression keeping physical log available in the crash recovery
Previous Message Jim Nasby 2007-02-02 03:46:48 Re: SQL to get a table columns comments?

Browse pgsql-patches by date

  From Date Subject
Next Message David Fetter 2007-02-02 05:11:42 Re: writing new regexp functions
Previous Message Jeremy Drake 2007-02-02 03:29:35 Re: [HACKERS] writing new regexp functions