Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Hannu Krosing <hannu(at)skype(dot)net>
Cc: Guido Goldstein <guido(dot)goldstein(at)a-nugget(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Date: 2007-01-31 12:57:37
Message-ID: 200701311257.l0VCvbv02414@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Hannu Krosing wrote:
> Officially by who ?
>
> 2.3 was the first version to introduce bool as a subtype of int, in
> 2.2.3 True and False were introduced as two variables pointing to
> integers 1 and 0.
>
> So to make your patch ok on all python versions, just make it
> conditional on python version being 2.3 or bigger, and return int for
> pre-2.3.

I thought about suggesting that, but do we want plpython to have
different result behavior based on the version of python used? I didn't
think so.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-31 13:34:25 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Previous Message Hannu Krosing 2007-01-31 09:08:00 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-31 13:34:25 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Previous Message Robert Bernier 2007-01-31 12:04:24 Re: Talks for OSCON? Only 5 days left!

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2007-01-31 13:34:25 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Previous Message Hannu Krosing 2007-01-31 09:08:00 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,