Skip site navigation (1) Skip section navigation (2)

Re: BCC55 and libpq 8.2

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: L Bayuk <lbayuk(at)pobox(dot)com>
Cc: pgsql-interfaces(at)postgresql(dot)org
Subject: Re: BCC55 and libpq 8.2
Date: 2007-01-08 15:54:23
Message-ID: 200701081554.l08FsNX24223@momjian.us (view raw or flat)
Thread:
Lists: pgsql-interfacespgsql-patches
L Bayuk wrote:
> On Fri, Jan 05, 2007 at 08:57:00PM -0500, Bruce Momjian wrote:
> > 
> > I have created the following patch based on your description of how to
> > get BCC compiled.  Please let me know how it works against a stock
> > PostgreSQL 8.2.X and I can include the patch in 8.2.2.  Sorry it didn't
> > make it in time for 8.2.1.
> 
> I understand about 8.2.1, and sorry for not getting to this sooner. I did
> have a patch file ready. I've compared it with the one you attached, and I
> have some questions.
> 
> 1. In the past, I've had to define "inline" to nothing to get libpq to compile
> with BCC, but I don't know if it is still necessary. I had that in my patch
> but you left it out. Do you know that this is no longer necessary, or
> should I test it?

We adjusted inline for 8.2 so I figured you will need to retest this
before we add it.

> 2. I also have a patch for bin/psql/bcc32.mak which basically synchronizes
> it to changes in win32.mak. With this patch, psql compiles with BCC -
> but it does not run well. (See my previous post on INTERFACES.) Can we
> include the patch anyway? Maybe someone will try to fix what's wrong
> someday and this patch will help.

Yes, let's do that.

> 3. To build libpq with BCC for use with pgtcl-ng, I had to add "-c" to the
> LINK32_FLAGS (makes symbols case sensitive, due to PQflush() vs pqFlush()
> if I recall), and change the runtime library from cw32mti.lib to cw32mt.lib
> (static version). I don't know if these are specific to linking with Tcl
> libraries, but I can't see it would hurt anyone else. Can I include these
> in the patch?

I did some research and it seems the MS linker is case-sensitive by
default, while BCC is case-insensitive by default, so that -c option is
something we definately should add to the bcc makefile.

> I will try your patch, and look into the inline thing as soon as I can,
> perhaps Monday.

Great.  Just send me a patch that works on your setup and I will apply
it.  Thanks.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-01-08 16:28:07
Subject: Re: [PATCHES] [Fwd: Index Advisor]
Previous:From: Peter EisentrautDate: 2007-01-08 08:57:21
Subject: Re: [HACKERS] SGML index build fix

pgsql-interfaces by date

Next:From: L BayukDate: 2007-01-09 00:34:08
Subject: Re: BCC55 and libpq 8.2
Previous:From: L BayukDate: 2007-01-07 23:19:09
Subject: Re: BCC55 and libpq 8.2

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group