Re: [PATCHES] Patch to log usage of temporary files

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bill Moran <wmoran(at)collaborativefusion(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Patch to log usage of temporary files
Date: 2007-01-06 22:28:39
Message-ID: 200701062228.l06MSdB08308@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Bill Moran wrote:
> In response to Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>
> > Bill Moran <wmoran(at)collaborativefusion(dot)com> writes:
> > > Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> > >>> Might be more robust to say
> > >>> if (trace_temp_files >= 0)
> >
> > > I specified in the GUC config that minimum allowable value is -1.
> >
> > I'd still tend to go with Andrew's suggestion because it makes this
> > particular bit of code self-defending against bad values. Yes, it's
> > reasonably safe given that bit of coding way over yonder in guc.c,
> > but there's no particularly good reason why this code has to depend
> > on that to avoid doing something stupid. And it's easier to understand
> > too --- you don't have to go looking in guc.c to convince yourself it's
> > safe.
>
> Ahh ... well, I've probably already argued about it more than it's worth.
> The patch is easy enough to adjust, find attached.
>
> --
> Bill Moran
> Collaborative Fusion Inc.

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
>
> http://www.postgresql.org/about/donate

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2007-01-06 22:39:23 Re: PGCon 2007 Program Committee
Previous Message Bruce Momjian 2007-01-06 22:18:33 Re: pg_ctl options

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-06 22:55:20 Re: Allow the identifier length to be increased via
Previous Message Euler Taveira de Oliveira 2007-01-06 21:53:05 Re: COPY with no WAL, in certain circumstances