Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Check for ERANGE in exp()

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Stefan Kaltenbrunner <stefan(at)kaltenbrunner(dot)cc>
Cc: Bruce Momjian <momjian(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Check for ERANGE in exp()
Date: 2007-01-06 20:20:46
Message-ID: 200701062020.l06KKkC22255@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Stefan Kaltenbrunner wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Check for ERANGE in exp() as well.
> 
> this broke the regression tests on a number of boxes:
> 
> http://buildfarm.postgresql.org/cgi-bin/show_status.pl
> 
> example:
> 
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sponge&dt=2007-01-06%2015:30:02

Thanks.  This is something I wanted to ask Tom about today.  I was
worried that ERANGE could be generated by underflow as well as overflow,
and setting result to Inf would not work for underflow.  I have applied
the following patch to test for != 0 and != Inf, which should elimintate
the underflow case.

Tom, on HPPA, does ERANGE get set for both overflow and underflow?  I
assume only overflow.

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /bjm/diff
Description: text/x-diff (1.2 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-01-06 20:24:02
Subject: Re: COPY with no WAL, in certain circumstances
Previous:From: Tom LaneDate: 2007-01-06 20:07:47
Subject: Re: Parsing ambiguity for ORDER BY ... NULLS FIRST/LAST

pgsql-committers by date

Next:From: Bruce MomjianDate: 2007-01-06 20:21:29
Subject: pgsql: Apply fix so pow() and exp() ERANGE is used only if result is not
Previous:From: Stefan KaltenbrunnerDate: 2007-01-06 20:07:28
Subject: Re: [COMMITTERS] pgsql: Check for ERANGE in exp() as well.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group