Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Numeric overflow problem + patch

From: David Fetter <david(at)fetter(dot)org>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] Numeric overflow problem + patch
Date: 2006-10-02 00:46:02
Message-ID: 20061002004602.GA18936@fetter.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Thu, Sep 28, 2006 at 11:16:56PM +0200, Martijn van Oosterhout wrote:
> On Thu, Sep 28, 2006 at 05:11:43PM -0400, Tom Lane wrote:
> > David Fetter <david(at)fetter(dot)org> writes:
> > > ! DETAIL:  A field with precision 4, scale 4 must have an absolute value less than 1.
> > > [ becomes ]
> > > ! DETAIL:  A field with precision 4, scale 4 must have an absolute value less than 1 - 5 * 10^-5.
> > 
> > This strikes me as overly pedantic.  The message needs to be clear,
> > and the proposed change will just confuse people.
> 
> I don't know if the code can detect the difference, but a message like:
> 
> A field with precision 4, scale 4 must *round to* an absolute value less than 1
> 
> Since that more accurately describes the actual problem.
> 
> Have a ncie day,

Per your suggestion, how about this patch?

Cheers,
D
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778        AIM: dfetter666
                              Skype: davidfetter

Remember to vote!

In response to

Responses

pgsql-hackers by date

Next:From: ITAGAKI TakahiroDate: 2006-10-02 01:52:48
Subject: Re: Another idea for dealing with cmin/cmax
Previous:From: Andrew DunstanDate: 2006-10-02 00:23:00
Subject: Re: Win32 hard crash problem

pgsql-patches by date

Next:From: Brendan JurdDate: 2006-10-02 03:13:58
Subject: ISO week dates
Previous:From: Euler Taveira de OliveiraDate: 2006-10-01 17:54:57
Subject: minor improvements in messages

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group