Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] [COMMITTERS] pgsql: Change FETCH/MOVE

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [COMMITTERS] pgsql: Change FETCH/MOVE
Date: 2006-09-03 03:24:40
Message-ID: 200609030324.k833Oet24439@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> >> This patch has broken half the buildfarm, and I've still not seen a
> >> rationale why we need to make such a change at all.
> 
> > Fixed with attached patch.  The use case for this was not FETCH, but
> > MOVE for > 2gig tables.
> 
> There is *no* credible use case for this (hint: MOVE FORWARD/BACKWARD
> ALL does not need this to work for >2G tables).  It is not worth the
> extra computational cycles that it imposes on every machine whether they
> use the feature or not, and it is certainly not worth the developer time
> we're expending to fix this poorly written patch.  Please revert it.

Already done because of bad coding.  You want the TODO item removed too?

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2006-09-03 03:39:33
Subject: Re: plpgsql, return can contains any expression
Previous:From: Tom LaneDate: 2006-09-03 03:22:35
Subject: Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.

pgsql-committers by date

Next:From: Bruce MomjianDate: 2006-09-03 03:26:42
Subject: pgsql: Reverted: < * -Change LIMIT/OFFSET and FETCH/MOVE to use int8 >
Previous:From: Tom LaneDate: 2006-09-03 03:22:35
Subject: Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-09-03 03:26:06
Subject: Re: Patch for - Change FETCH/MOVE to use int8
Previous:From: Tom LaneDate: 2006-09-03 03:22:35
Subject: Re: [COMMITTERS] pgsql: Change FETCH/MOVE to use int8.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group