Re: [HACKERS] [PATCHES] log_statement output for protocol

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Guillaume Smet <guillaume(dot)smet(at)gmail(dot)com>, Oliver Jowett <oliver(at)opencloud(dot)com>, Dave Cramer <pg(at)fastcrypt(dot)com>, Csaba Nagy <nagy(at)ecircle-ag(dot)com>, Postgres JDBC <pgsql-jdbc(at)postgresql(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] log_statement output for protocol
Date: 2006-08-29 02:22:33
Message-ID: 200608290222.k7T2MXW01278@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc pgsql-patches

BTom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Yes, I do. I have applied the attached patch to fix this issue and
> > several others. The fix was to save the bind parameters in the portal,
> > and display those in the executor output, if available.
>
> I have a feeling you just blew away the 4% savings in psql I've spent
> the evening on. What's the overhead of this patch?

The only overhead I see is calling log_after_parse() all the time,
rather than only when log_statement is all. I could fix it by checking
log_statement and log_min_duration_statement >= 0. Does
log_after_parse() look heavy to you?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-08-29 02:36:36 stats test on Windows is now failing repeatably?
Previous Message Tom Lane 2006-08-29 02:18:14 Re: [HACKERS] [PATCHES] log_statement output for protocol

Browse pgsql-jdbc by date

  From Date Subject
Next Message Bruce Momjian 2006-08-29 02:33:30 Re: [HACKERS] [PATCHES] log_statement output for protocol
Previous Message Tom Lane 2006-08-29 02:18:14 Re: [HACKERS] [PATCHES] log_statement output for protocol

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-08-29 02:33:30 Re: [HACKERS] [PATCHES] log_statement output for protocol
Previous Message Tom Lane 2006-08-29 02:18:14 Re: [HACKERS] [PATCHES] log_statement output for protocol