Re: Allow commenting of variables in postgresql.conf to - try3

From: Joachim Wieland <joe(at)mcknight(dot)de>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Allow commenting of variables in postgresql.conf to - try3
Date: 2006-06-03 18:23:53
Message-ID: 20060603182353.GA8462@mcknight.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Zdenek,

On Thu, Jun 01, 2006 at 04:56:10PM +0200, Zdenek Kotala wrote:
> Thanks, You have right. It is problem with silent skip some option in
> set_config_option function when PGC_SIGHUP is running context.

> I fix it and I attach third version of patch.

Still it does not what I think it should do. I might have been unclear
before. If you put a comment in front of a PGC_POSTMASTER variable (and if
its value differs from the default) then this should be treated as if the
variable got changed and it should emmit a warning "<varname> can only be
changed on server start" or similar. This warning should be kept for every
other SIGHUP that gets sent just like it is done already when you change the
value (but do not comment the variable).

I still have the problem that the first signal I send does not trigger any
message (i get the "SIGHUP received", but nothing about the variable
changes) but I haven't looked into it yet.

Joachim

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2006-06-03 18:46:07 Re: More thoughts about planner's cost estimates
Previous Message Ganesh Chaudhari 2006-06-03 16:59:58 Re: Problem building initdb on sparc10

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-06-04 00:15:34 Re: Update link for GUI Tools in FAQ
Previous Message Tom Lane 2006-06-03 16:51:47 Re: fix for incorrect russian translation