Re: [HACKERS] .pgpass file and unix domain sockets

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, joe(at)mcknight(dot)de
Subject: Re: [HACKERS] .pgpass file and unix domain sockets
Date: 2006-05-17 02:18:30
Message-ID: 200605170218.k4H2IUf20601@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


I have implemented the idea I listed below, patch attached.

---------------------------------------------------------------------------

Bruce Momjian wrote:
>
> Uh, why wouldn't we allow "localhost" to match the default unix domain
> socket name, as well as an empty hostname? If you specify a non-default
> location, you then have to specify the full path.
>
> ---------------------------------------------------------------------------
>
> Andrew Dunstan wrote:
> >
> > hackers - any opinions?
> >
> > The biggest downside would be that a pgpass file would be version
> > specific for this feature. The badness of this is somewhat mitigated by
> > the ability we now have to specify an alternative pgpassfile location.
> >
> > cheers
> >
> > andrew
> >
> > -------- Original Message --------
> > Subject: Re: [PATCHES] .pgpass file and unix domain sockets
> > Date: Tue, 16 May 2006 12:16:53 -0400
> > From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> > To: Andrew Dunstan <andrew(at)dunslane(dot)net>
> > CC: Joachim Wieland <joe(at)mcknight(dot)de>, pgsql-patches(at)postgresql(dot)org
> > References: <20060516122554(dot)GA4009(at)mcknight(dot)de>
> > <11676(dot)1147787022(at)sss(dot)pgh(dot)pa(dot)us> <4469F499(dot)1040002(at)dunslane(dot)net>
> > <13302(dot)1147795016(at)sss(dot)pgh(dot)pa(dot)us> <4469FA5A(dot)3090504(at)dunslane(dot)net>
> >
> >
> >
> > Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > > Tom Lane wrote:
> > >> Personally I wouldn't object to making it match "localhost" in all
> > >> cases. That's what the documentation says, and the use-case for
> > >> doing something more complicated seems pretty thin.
> >
> > > I almost agree. If anything, I'd prefer to provide for an explicit entry
> > > covering all Unix Domain sockets - it took me by some surprise to find a
> > > while back that "localhost" covers that case - it seems a mismatch with
> > > how pg_hba.conf works.
> >
> > Well, that'd break existing .pgpass files (unless we match localhost
> > too, which seems to defeat the purpose). But maybe it's worth doing
> > for consistency's sake. I think we should bring it up on a more
> > widely read list than -patches if you want to propose a
> > non-backwards-compatible change ...
> >
> >
> >
> >
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 1: if posting/reading through Usenet, please send an appropriate
> > subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> > message can get through to the mailing list cleanly
> >
>
> --
> Bruce Momjian http://candle.pha.pa.us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian http://candle.pha.pa.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Attachment Content-Type Size
unknown_filename text/plain 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-05-17 02:40:41 Re: pg_dump and backslash escapes
Previous Message David Wheeler 2006-05-17 02:07:12 Re: PL/pgSQL 'i = i + 1' Syntax

Browse pgsql-patches by date

  From Date Subject
Next Message Greg Stark 2006-05-17 03:48:21 Re: Compression and on-disk sorting
Previous Message Andrew Piskorski 2006-05-17 00:14:34 Re: Compression and on-disk sorting