Skip site navigation (1) Skip section navigation (2)

Re: restore to defaults values when commenting of variables

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: BERTHOULE Emmanuel <pgdev(at)manberth(dot)homeip(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: restore to defaults values when commenting of variables
Date: 2006-04-21 23:33:22
Message-ID: 200604212333.k3LNXM401395@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> BERTHOULE Emmanuel <pgdev(at)manberth(dot)homeip(dot)net> writes:
> > with this patch, you can now restore default value with SIGHUP when
> > commenting an variable in postgresql.conf
> 
> This seems pretty poorly thought out, in particular making PGC_S_SIGHUP
> >= PGC_S_OVERRIDE seems to me likely to break the interaction with other
> sources.  Doesn't that cause postgresql.conf to override per-user and
> per-database settings?  Why do you need the extra value at all ---
> isn't the correct logic just to reset entries with source PGC_S_FILE?
> 
> Another problem is that if there's something wrong with the config file,
> this will cause all values previously read from the config file to
> revert to defaults, which seems less than robust to me.  You really
> shouldn't apply the reset until after the file has been parsed.

Is any progress being made on this patch to address the above concerns?

-- 
  Bruce Momjian   http://candle.pha.pa.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2006-04-21 23:53:43
Subject: Re: proposal - plpgsql: execute using into
Previous:From: Bruce MomjianDate: 2006-04-21 23:30:10
Subject: Re: Win32 sysconfig -> pg_service.conf

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group