Skip site navigation (1) Skip section navigation (2)

Re: BUG #2246: Only call pg_fe_getauthname if none given

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: BUG #2246: Only call pg_fe_getauthname if none given
Date: 2006-02-15 20:05:26
Message-ID: 20060215200526.GM4474@ns.snowman.net (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> This is probably not a good idea --- changing the API behavior in
> pursuit of saving a few cycles is just going to get people mad at us.

Fair enough.

> I think we'd have to refactor the code so that PQsetdbLogin gets a
> PQconninfoOption array, overrides values *in that array*, then calls the
> fallback-substitution code etc.  Not sure if it's worth the trouble.
> The extra complexity of searching the array for values to override could
> eat up the cycles we're hoping to save, too :-(

Perhaps I'm missing something obvious (and if so, I'm sorry) but
couldn't we just build up the character array in PQsetdbLogin to be
passed in to connectOptions1?  If we do that we could probably also
merge the two connectOptions...  That would simplify things a great deal
I think and would also avoid the extra processing to pick up the
'defaults'...

	Stephen

In response to

Responses

pgsql-bugs by date

Next:From: Andrew KlostermanDate: 2006-02-15 20:14:59
Subject: Re: BUG #2246: Bad malloc interactions: ecpg, openssl
Previous:From: Tom LaneDate: 2006-02-15 20:02:45
Subject: Re: BUG #2260: PGCrypto Memory Problem

pgsql-patches by date

Next:From: Andrew KlostermanDate: 2006-02-15 20:14:59
Subject: Re: BUG #2246: Bad malloc interactions: ecpg, openssl
Previous:From: Tom LaneDate: 2006-02-15 19:19:29
Subject: Re: BUG #2246: Only call pg_fe_getauthname if none given

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group