Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kris Jurka <books(at)ejurka(dot)com>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align
Date: 2006-02-10 18:43:49
Message-ID: 20060210184349.GE576@svana.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
On Fri, Feb 10, 2006 at 06:16:07PM +0100, Martijn van Oosterhout wrote:
> Thanks for the tip. I'm currently merging CVS with my version and
> getting a lot of conflicts (whitespace variations). 
> 
> It's fairly simple changes AFAICS. Just need to fix the declarations of
> a few variables.

Does PostgreSQL have a policy on the signedness of strings? When I was
making the patch I generally used "unsigned char" to try to emphasise
that these are not characters, they are bytes of an encoding. But this
doesn't play well with existing functions like PQdsplen and PQmblen.

At this point I'm thinking of dropping the "unsigned" everywhere and
just being really careful of comparisons. OTOH, it's really those two
functions being inconsistant because the underlying functions do use
unsigned. Thoughts?

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

In response to

Responses

pgsql-committers by date

Next:From: Tom LaneDate: 2006-02-10 19:01:13
Subject: pgsql: Change search for default operator classes so that it examines
Previous:From: Martijn van OosterhoutDate: 2006-02-10 17:16:07
Subject: Re: [COMMITTERS] pgsql: Allow psql multi-line column values to align

pgsql-patches by date

Next:From: Tom LaneDate: 2006-02-10 19:04:29
Subject: Re: Scrollable cursors and Sort performance
Previous:From: Martijn van OosterhoutDate: 2006-02-10 18:14:12
Subject: Re: Scrollable cursors and Sort performance

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group