Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Should libedit be preferred to libreadline?

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Zeugswetter Andreas DCP SD <ZeugswetterA(at)spardat(dot)at>
Cc: Seneca Cunningham <scunning(at)ca(dot)afilias(dot)info>,pgsql-hackers(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org,pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-11-22 09:57:47
Message-ID: 20051122095747.GA12548@svana.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patchespgsql-ports
On Tue, Nov 22, 2005 at 10:07:15AM +0100, Zeugswetter Andreas DCP SD wrote:
> PS: I'd prefer if readline was only linked where it is needed, namely in
> psql.

The problem as stated is that people don't want to maintain lists of
libraries as needed by each program, so we link all of them.

Since it seems to always be the same few libraries that cause us
problems, maybe a simpler approach would be to, in the Makefile, use
filter-out to exclude libraries you *know* aren't needed. Like in the
Makefile we put:

postgres: $(OBJS)
        $(CC) $(CFLAGS) $(LDFLAGS) $(export_dynamic) $^ $(filter-out -lreadline -ledit, $(LIBS)) -o $@

So instead of maintaining lists of what each binary needs, we can
maintain a few lists of what certain binaries *don't* need. Actually, I
think the backend is the only thing important enough to worry about
this, although if readline is exporting memcpy that it's quite possible
other binaries might be affected. Maybe create a BACKEND_LIBS which
contains a shorter list.

Even the GCC --as-needed flag can't save you from libs exporting
functions they shouldn't...

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

In response to

Responses

pgsql-ports by date

Next:From: Jim C. NasbyDate: 2005-11-22 20:49:24
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Zeugswetter Andreas DCP SDDate: 2005-11-22 09:07:15
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

pgsql-hackers by date

Next:From: Martijn van OosterhoutDate: 2005-11-22 10:11:42
Subject: Re: Web page down (ad server)
Previous:From: gevikDate: 2005-11-22 09:57:19
Subject: TODO item "%Allow pg_hba.conf be controlled via SQL"

pgsql-patches by date

Next:From: Jim C. NasbyDate: 2005-11-22 20:49:24
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Zeugswetter Andreas DCP SDDate: 2005-11-22 09:07:15
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group