Repair an error introduced by log_line_prefix patch: it is not acceptable
to assume that the string pointer passed to set_ps_display is good forever.
There's no need to anyway since ps_status.c itself saves the string, and
we already had an API (get_ps_display) to return it.
I believe this explains Jim Nasby's report of intermittent crashes in
elog.c when %i format code is in use in log_line_prefix.
While at it, repair a previously unnoticed problem: on some platforms such as
Darwin, the string returned by get_ps_display was blank-padded to the maximum
length, meaning that lock.c's attempt to append " waiting" to it never worked.
postmaster.c (r1.474 -> r1.475)
lock.c (r1.158 -> r1.159)
elog.c (r1.166 -> r1.167)
ps_status.c (r1.25 -> r1.26)
libpq-be.h (r1.52 -> r1.53)
ps_status.h (r1.25 -> r1.26)
pgsql-committers by date
|Next:||From: Tom Lane||Date: 2005-11-05 03:05:05|
|Subject: pgsql: Repair an error introduced by log_line_prefix patch: it is not |
|Previous:||From: Bruce Momjian||Date: 2005-11-05 01:38:44|
|Subject: pgsql: Add mention to update FAQ item on most recent release to |