Re: [BUGS] Bug#333854: pg_group file update problems

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dennis Vshivkov <walrus(at)amur(dot)ru>, 333854(at)bugs(dot)debian(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] Bug#333854: pg_group file update problems
Date: 2005-10-14 17:37:56
Message-ID: 200510141737.j9EHbu426768@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > In the patch, notice the old comment that suggests we might need to use
> > CommandCounterIncrement().
>
> ... which you failed to fix in any meaningful way. I'd suggest
>
> /*
> * Advance the commmand counter to ensure we see all results
> * of current transaction.
> */
> CommandCounterIncrement();
>
> and then change SnapshotSelf to SnapshotNow, since there's no longer any
> reason for it to be special. Compare to CVS tip which already does it
> that way. See also the identical code in write_user_file (which perhaps
> has no bug, but ISTM it should stay identical).

OK, updated patch.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 2.3 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2005-10-14 18:18:32 Re: [BUGS] Bug#333854: pg_group file update problems
Previous Message Martin Pitt 2005-10-14 17:13:35 Re: BUG #1963: SSL certificate permission check is too strict

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-10-14 18:18:32 Re: [BUGS] Bug#333854: pg_group file update problems
Previous Message Tom Lane 2005-10-14 15:55:32 Re: [BUGS] Bug#333854: pg_group file update problems