Re: plperl: enable UTF-8 support

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: David Kamholz <davekam(at)pobox(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: plperl: enable UTF-8 support
Date: 2005-06-10 15:58:09
Message-ID: 200506101558.j5AFw9528645@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


It seems the plperl code has changed in the areas you are modifying.
Would you update your patch against current CVS? Thanks.

---------------------------------------------------------------------------

David Kamholz wrote:
> Hello,
>
> Here's a patch I added against plperl, originally against beta5, now
> against rc1. It simply checks with GetDatabaseEncoding() if the current
> database is in UTF-8, and if so, sets the UTF-8 flag on the arguments
> that are passed to perl. This means that it isn't necessary to
> utf8::upgrade() every string, as perl has no way of knowing offhand
> that a string is UTF-8 -- but postgres does, because the database
> encoding is specified, so it makes sense to turn the flag on. You
> should also be able to properly manipulate UTF-8 strings now from
> plperl as opposed to plperlu, because otherwise you'd have to use
> encoding 'utf8' which was not allowed. It could also eliminate some
> unexpected bugs if you assume that perl knows the string is unicode. It
> is enabled only for perl 5.6 and higher, so earlier versions will not
> be affected.
>
> I have been assured by crab that the patch is quite harmless and will
> not break anything. It would be great to see it in 8 final! :-)
>
> Regards,
> Dave
>

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2005-06-10 16:00:10 Re: bugfix: character-code conversion of MIC -> EUC_JP.
Previous Message Bruce Momjian 2005-06-10 15:46:41 Re: psql: customizable readline history filename