Re: [PATCHES] Adding \x escape processing to COPY, psql, backend

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sergey Ten <sergey(at)sourcelabs(dot)com>, "'Christopher Kings-Lynne'" <chriskl(at)familyhealth(dot)com(dot)au>, jason(at)sourcelabs(dot)com, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [PATCHES] Adding \x escape processing to COPY, psql, backend
Date: 2005-05-30 20:15:46
Message-ID: 200505302015.j4UKFke23797@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Here is a new version of the three \x hex support patches. I have added
> > \x for psql variables, which is the last patch.
>
> > I have IM'ed with Peter and he is now OK with the idea of supporting \x,
> > with the underestanding that it doesn't take us any farther away from
> > compatibility than we are now.
>
> Peter may be OK with it, but I object strongly to adding this to SQL
> literals. This is exactly *not* the direction we want to be going in.
>
> I don't really see the point for COPY and psql, either.

We already support \n, \r, \t, and \octal. I don't see any problem with
improving it. It does not take us any closer or farther away from spec
compliance.

COPY \x has been requested by several people, and there are actually two
patches that have been submitted in the past year for this.

As you know, escapes already provide a useful mechanism on COPY and SQL
strings, and there is a plan I just posted to deal with standards
issues, but I don't see \x taking us closer or farther from this.

Please explain why this takes us in the wrong direction.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-05-30 21:08:23 Re: [HACKERS] Inherited constraints and search paths (was
Previous Message Bruce Momjian 2005-05-30 20:11:08 Backslash handling in strings

Browse pgsql-patches by date

  From Date Subject
Next Message Gladys 2005-05-30 21:35:40 Platinum Stock Reports
Previous Message Bruce Momjian 2005-05-30 20:11:08 Backslash handling in strings