I have applied a modified version of your patch, attached.
initdb will not work without %*s support, so I had to add that. Please
look over my work. I don't think i handle %*1$ but I am not even sure
what that means or if our translators would ever use such a thing. You
can probably test that better than I can.
Your patch didn't handle signed vs. unsigned va_arg values properly..
There were also maxwidth tests around 's' that I had to remove to
support %*. I think those tests are down in fmtstr too but please
initdb and regression pass.
Nicolai Tufar wrote:
> Resubmission of yesterday's patch so that it would
> cont conflict with Bruce's cvs commit. Pleas apply.
> Best regards,
> On Sat, 12 Mar 2005 01:58:15 +0200, Nicolai Tufar <ntufar(at)gmail(dot)com> wrote:
> > On Thu, 10 Mar 2005 19:21:41 -0500 (EST), Bruce Momjian
> > <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > > > The CVS-tip implementation is fundamentally broken and won't work even
> > > > for our internal uses. I've not wasted time complaining about it
> > > > because I thought we were going to replace it. If we can't find a
> > > > usable replacement then we're going to have to put a lot of effort
> > > > into fixing what's there. On the whole I think the effort would be
> > > > better spent importing someone else's solution.
> > >
> > > Oh, so our existing implementation doesn't even meet our needs. OK.
> > Which made me wander why did I not aggree with
> > Tom Lane's suggestion to make do three passes
> > instead of two. Tom was right, as usual. It happened to
> > be much easier than I expected. The patch is attached.
> > Please apply.
> > Tom, what do you think? Will it be fine with you?
> > Best regards,
> > Nicolai
[ Attachment, skipping... ]
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-hackers by date
|Next:||From: Mark Kirkwood||Date: 2005-03-16 08:47:31|
|Subject: Re: contrib/pg_buffercache|
|Previous:||From: Christopher Kings-Lynne||Date: 2005-03-16 05:36:47|
|Subject: Re: PQexecParams|
pgsql-patches by date
|Next:||From: Bruce Momjian||Date: 2005-03-16 06:05:58|
|Subject: Re: [COMMITTERS] pgsql: Handle carriage returns and line feeds in COPY|
|Previous:||From: Neil Conway||Date: 2005-03-16 05:47:10|
|Subject: Re: Sort psql output|
pgsql-hackers-win32 by date
|Next:||From: Nicolai Tufar||Date: 2005-03-16 11:36:50|
|Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests to fail|
|Previous:||From: Bruce Momjian||Date: 2005-03-16 00:47:50|
|Subject: Re: [pgsql-hackers-win32] UNICODE/UTF-8 on win32|