Re: [pgsql-hackers-win32] snprintf causes regression

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: pgsql(at)mohawksoft(dot)com
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression
Date: 2005-03-11 04:10:12
Message-ID: 200503110410.j2B4ACx27187@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

pgsql(at)mohawksoft(dot)com wrote:
> > Tom Lane wrote:
> >> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> > Please see my posting about using a macro for snprintf. If the
> >> current
> >> > implementation of snprintf is enough for our existing translation
> >> users
> >> > we probably don't need to add anything more to it because snprintf
> >> will
> >> > not be exported to client applications.
> >>
> >> The CVS-tip implementation is fundamentally broken and won't work even
> >> for our internal uses. I've not wasted time complaining about it
> >> because I thought we were going to replace it. If we can't find a
> >> usable replacement then we're going to have to put a lot of effort
> >> into fixing what's there. On the whole I think the effort would be
> >> better spent importing someone else's solution.
> >
> > Oh, so our existing implementation doesn't even meet our needs. OK.
>
> Wasn't the issue about odd behavior of the Win32 linker choosing the wrong
> vnsprintf?

Ah, but with my new patch to be applied tomorrow to use macros and
rename to pg_snprintf there no longer is any conflict with the system
versions of these functions.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Wright 2005-03-11 05:45:18 Re: BUG #1528: Rows returned that should be excluded by WHERE clause
Previous Message Tom Lane 2005-03-11 03:58:27 Re: [pgsql-hackers-win32] snprintf causes regression tests

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-11 05:58:11 Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Previous Message Tom Lane 2005-03-11 03:58:27 Re: [pgsql-hackers-win32] snprintf causes regression tests

Browse pgsql-patches by date

  From Date Subject
Next Message Nicolai Tufar 2005-03-11 05:58:11 Re: [pgsql-hackers-win32] snprintf causes regression tests to fail
Previous Message Tom Lane 2005-03-11 03:58:27 Re: [pgsql-hackers-win32] snprintf causes regression tests