Re: [pgsql-hackers-win32] snprintf causes regression tests

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] snprintf causes regression tests
Date: 2005-03-11 00:21:41
Message-ID: 200503110021.j2B0LfV18748@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Please see my posting about using a macro for snprintf. If the current
> > implementation of snprintf is enough for our existing translation users
> > we probably don't need to add anything more to it because snprintf will
> > not be exported to client applications.
>
> The CVS-tip implementation is fundamentally broken and won't work even
> for our internal uses. I've not wasted time complaining about it
> because I thought we were going to replace it. If we can't find a
> usable replacement then we're going to have to put a lot of effort
> into fixing what's there. On the whole I think the effort would be
> better spent importing someone else's solution.

Oh, so our existing implementation doesn't even meet our needs. OK.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John R Pierce 2005-03-11 00:32:53 Re: We are not following the spec for HAVING without GROUP
Previous Message Tom Lane 2005-03-11 00:10:29 Re: Functions and transactions

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message pgsql 2005-03-11 01:29:49 Re: [pgsql-hackers-win32] snprintf causes regression
Previous Message Tom Lane 2005-03-10 23:55:06 Re: [pgsql-hackers-win32] snprintf causes regression tests to fail

Browse pgsql-patches by date

  From Date Subject
Next Message pgsql 2005-03-11 01:29:49 Re: [pgsql-hackers-win32] snprintf causes regression
Previous Message Tom Lane 2005-03-11 00:10:29 Re: Functions and transactions