Re: dbsize patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Ed L(dot)" <pgsql(at)bluepolka(dot)net>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: dbsize patch
Date: 2005-02-26 23:32:37
Message-ID: 200502262332.j1QNWbg11245@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Patch applied. Thanks.

I renamed aggregate_relation_size() to total_relation_size(). To me
'aggregate' was too closely associated with 'aggregates'. If you have
improved wording please let me know.

---------------------------------------------------------------------------

Ed L. wrote:
> On Thursday February 3 2005 9:23, Ed L. wrote:
> > Neil, do you have a verdict on this patch?
> >
> > On Friday January 28 2005 10:30, Ed L. wrote:
> > > If the C code for the prior dbsize patch is not acceptable
> > > for whatever reason, here's a SQL-based patch to replace it.
>
> I submitted a dbsize patch on Jan 25, revised it twice per
> concerns raised by Michael Paesold and Neil Conway ("indexes"
> instead of "indices") and Andreas Pflug and Tom Lane (implement
> in SQL instead of C) and resubmitted Jan 28. I've not received
> any further communication regarding the patch. Please advise if
> there are concerns. I've attached the patch again, slightly
> cleaned up, in case it has fallen through the cracks.
>
> Ed

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message lsunley 2005-02-26 23:49:36 Re: [HACKERS] UTF8 or Unicode
Previous Message lsunley 2005-02-26 23:08:52 Re: [HACKERS] UTF8 or Unicode