Skip site navigation (1) Skip section navigation (2)

Re: libpq build problem with <io.h> on MS VC++

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Francis <locust(at)familyhealth(dot)com(dot)au>,pgsql-hackers-win32(at)postgresql(dot)org,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq build problem with <io.h> on MS VC++
Date: 2004-08-17 03:52:45
Message-ID: 200408170352.i7H3qjo21315@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I have improved your comment and applied the patch. I mentioned the
> > problem is only on MS C, but we might as well include io.h there on all
> > Win32 platforms.
> 
> I am actually fairly uncomfortable with this solution.  We learned the
> hard way awhile back that we want to include postgres.h or siblings
> *before* any system header file, because the system header files may
> default to things we do not want otherwise.  (Typical examples have to
> do with 32-bit vs 64-bit file offsets.)  Perhaps it will be okay to
> violate that rule on this one specific file on this one specific
> platform, but I would not bet on it.

The only other option I can think of is to #undef those to defines,
include io.h, then re-include port.h?  Is that better?

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2004-08-17 03:56:37
Subject: Re: libpq build problem with <io.h> on MS VC++
Previous:From: Tom LaneDate: 2004-08-17 03:21:12
Subject: Re: libpq build problem with <io.h> on MS VC++

pgsql-hackers-win32 by date

Next:From: Tom LaneDate: 2004-08-17 03:56:37
Subject: Re: libpq build problem with <io.h> on MS VC++
Previous:From: Tom LaneDate: 2004-08-17 03:21:12
Subject: Re: libpq build problem with <io.h> on MS VC++

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group