Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Cannot initdb in cvs tip

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Cannot initdb in cvs tip
Date: 2004-07-31 05:51:09
Message-ID: 200407310551.i6V5p9g29666@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Looks good. I will have to do a little adjustment because dirmod is
currently only used by Win32.

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Andrew Dunstan wrote:
> 
> 
> Bruce Momjian wrote:
> 
> >Andrew Dunstan wrote:
> >  
> >
> >>>I wanted to keep a solution that was as native to the OS as possible,
> >>>but because we can't do that on Win32 and few people like the unix
> >>>system call to 'rm', it is time to clean it up.
> >>>
> >>>One question --- why is there a sleep loop needed for unlink in your
> >>>patch?
> >>>
> >>> 
> >>>
> >>>
> >>>      
> >>>
> >>We will just be calling the existing pgunlink() (which has a sleep) in 
> >>the Windows cases, so this question becomes moot.
> >>    
> >>
> >
> >Great.  Thanks.  Sorry I delayed addressing this for so long.
> >  
> >
> 
> Please check the enclosed patch to see if it does what you want.
> 
> >Should we look at replacing cp/copy in 7.6?
> >
> >  
> >
> 
> probably. Put it as a possible TODO maybe.
> 
> cheers
> 
> andrew
> 
> 


> 
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Zoltan BartkoDate: 2004-07-31 07:08:10
Subject: psql i18n - sk
Previous:From: Mark KirkwoodDate: 2004-07-31 00:39:01
Subject: Re: Point in Time Recovery

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-07-31 06:21:14
Subject: Re: Borland c++ compile problems...
Previous:From: Bruce MomjianDate: 2004-07-31 04:41:27
Subject: Fix for initdb translation

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2004-07-31 06:21:14
Subject: Re: Borland c++ compile problems...
Previous:From: Bruno Wolff IIIDate: 2004-07-30 15:30:49
Subject: Re: [ADMIN] Secure DB Systems - How to

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group