Re: pgsql-server: Use canonicalize_path for -D, GUC paths,

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql-server: Use canonicalize_path for -D, GUC paths,
Date: 2004-07-12 00:08:44
Message-ID: 200407120008.i6C08iF15879@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> None of these are correct. canonicalize_path is only intended for
> >> directory names not file names. (I think the same problem applies
> >> to several of your GUC variable changes, too.)
>
> > canonicalize_path changes \ to /, and trims the trailing slash.
>
> ... and probably breaks the GUC variables that represent search paths,
> rather than single file/directory names. Certainly canonicalizing those
> values in toto will not have the desired effects; you'd need to
> canonicalize the path elements after they are extracted.

OK, the only GUC I saw that was a list was preload_libraries, and this
patch fixes that.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.2 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2004-07-12 00:09:10 pgsql-server: Canonicalize preload_libraries after it is split up, not
Previous Message Tom Lane 2004-07-12 00:02:47 Re: pgsql-server: Use canonicalize_path for -D, GUC paths, and paths coming