Re: Compiling libpq with VisualC

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Compiling libpq with VisualC
Date: 2004-06-04 13:30:35
Message-ID: 200406041330.i54DUZg21687@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches


Patch applied. I didn't realize that file was for win32 _client_
compiles, and I didn't realize it had no pg_config_paths.h.

---------------------------------------------------------------------------

Andreas Pflug wrote:
> Bruce Momjian wrote:
>
> >Andreas Pflug wrote:
> >
> >
> >>Bruce Momjian wrote:
> >>
> >>
> >>
> >>>
> >>>
> >>>
> >>>
> >>>>>fe-connect.c:
> >>>>>- pg_config_paths.h isn't available. SYSCONFDIR is already defined so
> >>>>>fe-connect.c doesn't need to include that.
> >>>>>patch appended
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>This shouldn't be needed anymore. Where is SYSCONFDIR coming from? Is
> >>>it from some Win32 include file? It should only be coming from
> >>>pg_config_paths.h now.
> >>>
> >>>
> >>>
> >>>
> >>It's defined in pg_config.h.win32, which is copied to pg_config.h.
> >>There's no pg_config_paths.h for win32, and I wonder if the code which
> >>uses SYSCONFDIR is of any use for win32.
> >>
> >>
> >
> >Thanks. Removed. I never saw that because the file has a .win32
> >extension and my search tools didn't look in there.
> >
> >
> Well, that doesn't work like this. As I already wrote, there's no
> SYSCONFDIR, and if there was it can't have any sensible value for win32
> clients. SYSCONFDIR as of pg_config.h.win32 version 1.13 was just a
> dummy to make the compiler happy. Now there's no SYSCONFDIR around, and
> no pg_config_paths.h either...
>
> The attached patch will create a dummy pg_config_paths.h. Additionally,
> ENABLE_THREAD_SAFETY is supported by the makefile (but not by the
> sources, which need some rework)
>
> Regards,
> Andreas
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Pflug 2004-06-04 13:36:52 Re: Compiling libpq with VisualC
Previous Message Frank Wiles 2004-06-04 13:25:42 Re: Converting postgresql.conf parameters to kilobytes

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Andreas Pflug 2004-06-04 13:36:52 Re: Compiling libpq with VisualC
Previous Message Andreas Pflug 2004-06-04 08:36:40 Re: Compiling libpq with VisualC

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Pflug 2004-06-04 13:36:52 Re: Compiling libpq with VisualC
Previous Message Bruce Momjian 2004-06-04 13:24:57 Re: [HACKERS] pg_dump --comment?