Re: temp patch for win32 readdir issue

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: temp patch for win32 readdir issue
Date: 2004-02-12 20:27:18
Message-ID: 200402122027.i1CKRIE04739@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


We will document this on the win32 TODO list and remove this patch once
MinGW is fixed.

Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Magnus Hagander wrote:
> Ok, so I know this is pretty ugly. But there is a bug in mingw (current
> release - it's fixed in the snapshot version) with regards to readdir()
> (see previous mails on win32-hackers). Basically, it doesn't set errno
> correctly.
>
> This patch will catch this error with regards to the readdir(), wrap a
> change in #ifdef WIN32, and emit a warning at compile time. This is a
> temporary measure until mingw releases a version that has this fixed.
>
> Applying this will make it easier on those who want to compile
> postgresql on win32, since it removes a manual step. Which is why I'm
> giving it a shot posting it here even though it's ugly.
>
> //Magnus

Content-Description: win32_readdir.patch

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 7: don't forget to increase your free space map settings

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-02-12 20:30:39 Re: temp patch for win32 readdir issue
Previous Message Magnus Hagander 2004-02-12 20:22:43 win32 setitimer implementation