Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Proposed dirmod.c fix for Win32

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>
Cc: PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [PATCHES] Proposed dirmod.c fix for Win32
Date: 2004-02-02 22:03:50
Message-ID: 200402022203.i12M3op20202@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Claudio Natoli wrote:
> 
> For application to HEAD, pending community review (rationale provided below
> in previous message; no responses hopefully indicates agreement :-)
> 
> Following application, dirmod.c must be moved to src/backend/port/win32 (ie.
> add to src/backend/port/win32, and remove from src/port). 
> 
> [changes to configure.in are essentially only the removal of
> AC_LIBOBJ(dirmod); other changes to configure.in appear in a previous patch
> and yet to be applied]

I made more adjustments to configure/configure.in, attached, that should
have this working fine now.

> Please note that dirmod.c has recently been changed to work under cygwin,
> along side of the existing win32/mingw implementation, however does not
> currently appear, afaics, to be included during a cygwin build. This patch
> does not address this deficiency.

OK, I have addressed the cygwin issue in this patch.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Andrew DunstanDate: 2004-02-02 22:18:08
Subject: Re: fix memcpy() overlap
Previous:From: Bruce MomjianDate: 2004-02-02 21:48:26
Subject: Re: [pgsql-hackers-win32] Proposed dirmod.c fix for Win32

pgsql-hackers-win32 by date

Next:From: Andrew DunstanDate: 2004-02-02 22:11:47
Subject: Re: [HACKERS] What's left?
Previous:From: Bruce MomjianDate: 2004-02-02 21:48:26
Subject: Re: [pgsql-hackers-win32] Proposed dirmod.c fix for Win32

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group