Skip site navigation (1) Skip section navigation (2)

Re: nitpick consistency patch for pg_dump.c

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: nitpick consistency patch for pg_dump.c
Date: 2003-07-27 03:47:33
Message-ID: 200307270347.h6R3lXW09406@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Newer patch applied.  Thanks.

---------------------------------------------------------------------------



Andrew Dunstan wrote:
> 
> This is a totally trivial patch for something that was a very minor nit that
> annoyed me the other day while I was documenting my current project. It
> makes pg_dump use the same layout for types as for tables, by putting "\n\t"
> before the first field and "\n" before the final ");"
> 
> Can't really justify this too much except to say I had an itch and I
> scratched it ;-)
> 
> cheers
> 
> andrew
> 
> 
> 
> *** pg_dump.c~  2003-06-25 00:08:19.000000000 -0400
> --- pg_dump.c   2003-07-17 15:34:52.000000000 -0400
> ***************
> *** 3412,3418 ****
>         i_attname = PQfnumber(res, "attname");
>         i_atttypdefn = PQfnumber(res, "atttypdefn");
> 
> !       appendPQExpBuffer(q, "CREATE TYPE %s AS (",
>                                           fmtId(tinfo->typname));
> 
>         for (i = 0; i < ntups; i++)
> --- 3412,3418 ----
>         i_attname = PQfnumber(res, "attname");
>         i_atttypdefn = PQfnumber(res, "atttypdefn");
> 
> !       appendPQExpBuffer(q, "CREATE TYPE %s AS (\n",
>                                           fmtId(tinfo->typname));
> 
>         for (i = 0; i < ntups; i++)
> ***************
> *** 3423,3433 ****
>                 attname = PQgetvalue(res, i, i_attname);
>                 atttypdefn = PQgetvalue(res, i, i_atttypdefn);
> 
> !               if (i > 0)
> !                       appendPQExpBuffer(q, ",\n\t");
> !               appendPQExpBuffer(q, "%s %s", fmtId(attname), atttypdefn);
>         }
> !       appendPQExpBuffer(q, ");\n");
> 
>         /*
>          * DROP must be fully qualified in case same name appears in
> --- 3423,3431 ----
>                 attname = PQgetvalue(res, i, i_attname);
>                 atttypdefn = PQgetvalue(res, i, i_atttypdefn);
> 
> !               appendPQExpBuffer(q, "\n\t%s %s", fmtId(attname),
> atttypdefn);        }
> !       appendPQExpBuffer(q, "\n);\n");
> 
>         /*
>          * DROP must be fully qualified in case same name appears in
> 
> 
> 
> 
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2003-07-27 03:47:46
Subject: Re: nitpick consistency patch for pg_dump.c
Previous:From: Bruce MomjianDate: 2003-07-27 03:34:45
Subject: Re: psql patches for win32

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group