Re: Sequence patch has problems

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Sequence patch has problems
Date: 2003-03-21 03:55:55
Message-ID: 200303210355.h2L3ttR17041@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Here is the fix, applied. It was assigning NULL to an int32. Strange
my compiler didn't complain.

---------------------------------------------------------------------------

Tom Lane wrote:
> I assume these are from the recently-applied sequence patch:
>
> sequence.c: In function `DefineSequence':
> sequence.c:99: warning: assignment makes integer from pointer without a cast
> sequence.c:100: warning: assignment makes integer from pointer without a cast
> sequence.c:101: warning: assignment makes integer from pointer without a cast
> sequence.c:102: warning: assignment makes integer from pointer without a cast
> sequence.c:103: warning: assignment makes integer from pointer without a cast
> sequence.c: In function `init_params':
> sequence.c:882: warning: comparison between pointer and integer
> sequence.c:883: warning: comparison between pointer and integer
> sequence.c:920: warning: comparison between pointer and integer
> sequence.c:931: warning: comparison between pointer and integer
> sequence.c:943: warning: comparison between pointer and integer
> sequence.c:966: warning: comparison between pointer and integer
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 3.3 KB

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2003-03-21 04:25:17 Add CLUSTER ON to pg_dumps
Previous Message Bruce Momjian 2003-03-21 03:40:03 Re: psql patch