From: | Lennert Buytenhek <buytenh(at)gnu(dot)org> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | PGRES_POLLING_ACTIVE is unused... |
Date: | 2003-02-26 16:31:08 |
Message-ID: | 20030226163108.GA1355@gnu.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
...any reason why it is there at all?
(Please CC, not on this list.)
diff -urN postgresql-7.3.2.orig/doc/src/sgml/libpq.sgml postgresql-7.3.2/doc/src/sgml/libpq.sgml
--- postgresql-7.3.2.orig/doc/src/sgml/libpq.sgml 2003-01-30 20:50:07.000000000 +0100
+++ postgresql-7.3.2/doc/src/sgml/libpq.sgml 2003-02-26 17:20:34.000000000 +0100
@@ -316,9 +316,7 @@
</para>
<para>
If <function>PQconnectStart</> succeeds, the next stage is to poll <application>libpq</> so that it may
- proceed with the connection sequence. Loop thus: Consider a connection
- <quote>inactive</quote> by default. If <function>PQconnectPoll</function> last returned <symbol>PGRES_POLLING_ACTIVE</>,
- consider it <quote>active</quote> instead. If <function>PQconnectPoll(conn)</function> last returned
+ proceed with the connection sequence. Loop thus: If <function>PQconnectPoll(conn)</function> last returned
<symbol>PGRES_POLLING_READING</symbol>, perform a <function>select()</> for reading on <function>PQsocket(conn)</function>. If
it last returned <symbol>PGRES_POLLING_WRITING</symbol>, perform a <function>select()</> for writing on
<function>PQsocket(conn)</function>. If you have yet to call <function>PQconnectPoll</function>, i.e. after the call
diff -urN postgresql-7.3.2.orig/src/interfaces/libpq/fe-connect.c postgresql-7.3.2/src/interfaces/libpq/fe-connect.c
--- postgresql-7.3.2.orig/src/interfaces/libpq/fe-connect.c 2003-01-30 20:50:07.000000000 +0100
+++ postgresql-7.3.2/src/interfaces/libpq/fe-connect.c 2003-02-26 17:19:04.000000000 +0100
@@ -1090,9 +1090,6 @@
*/
switch (flag)
{
- case PGRES_POLLING_ACTIVE:
- break;
-
case PGRES_POLLING_OK:
return 1; /* success! */
@@ -1804,9 +1801,6 @@
*/
switch (flag)
{
- case PGRES_POLLING_ACTIVE:
- break;
-
case PGRES_POLLING_OK:
return true; /* success! */
diff -urN postgresql-7.3.2.orig/src/interfaces/libpq/libpq-fe.h postgresql-7.3.2/src/interfaces/libpq/libpq-fe.h
--- postgresql-7.3.2.orig/src/interfaces/libpq/libpq-fe.h 2002-09-04 22:31:47.000000000 +0200
+++ postgresql-7.3.2/src/interfaces/libpq/libpq-fe.h 2003-02-26 17:19:22.000000000 +0100
@@ -65,7 +65,6 @@
PGRES_POLLING_READING, /* These two indicate that one may */
PGRES_POLLING_WRITING, /* use select before polling again. */
PGRES_POLLING_OK,
- PGRES_POLLING_ACTIVE /* Can call poll function immediately. */
} PostgresPollingStatusType;
typedef enum
From | Date | Subject | |
---|---|---|---|
Next Message | greg | 2003-02-26 20:46:15 | XML ouput for psql |
Previous Message | John Cochran | 2003-02-26 03:01:03 | Patch to fix horology regression failure |