CVSROOT:	/cvsroot
Module name:	pgsql-server
Changes by:	momjian(at)postgresql(dot)org	02/12/12 17:49:27

Modified files:
	doc/src/sgml   : pygresql.sgml 
	src/interfaces/python: pg.py 

Log message:
	> There is an ugly little problem with the DB wrapper class.
	>
	> In pg.py the attributes of DB are defined as being the same as
	> the attributes of the corresponding pgobject "db", using the following
	
	...
	
	> The problem is that the attributes of db (which are read only)
	> are not static (they are actually function calls to PostgreSQL),
	> especially "status" and "error", but those attributes are copied
	> and this is done only once when initializing the DB object.
	>
	> So, in effect, only the attribute "db.error" of a DB instance
	> will be updated, but not the attribute "error". Same with "status".
	
	> Don't copy the (read only) attributes of the pgobject to the
	> DB object, but only the methods, and all of them, like this:
	>
	> --------------- change in pg.py ------------------
	> # Create convience methods, in a way that is still overridable.
	> for e in self.db.__methods__:
	>  setattr(self, e, getattr(self.db, e))
	> ----------------------------------------------------
	>
	> Furthermore, make an addition to the documentation of the
	> DB wrapper class (i.e. in pygresql-pg-db.html):
	> After the sentence "All pgobject methods are included in this class also."
	> add the following sentence "The pgobject read-only attributes can be
	> accessed py adding the prefix 'db.' to them."
	
	Christoph Zwerschke

pgsql-committers by date

Next:	From: Bruce Momjian - CVS	Date: 2002-12-13 05:36:24
	Subject: pgsql-server/src/bin/psql tab-complete.c
Previous:	From: Bruce Momjian - CVS	Date: 2002-12-12 22:42:39
	Subject: pgsql-server/src backend/libpq/be-secure.c int ...