Skip site navigation (1) Skip section navigation (2)

Re: fix memory leaks in pg_dump

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: fix memory leaks in pg_dump
Date: 2002-11-27 22:20:03
Message-ID: 200211272220.gARMK3V08976@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Sorry I hadn't gotten to adding your identical submission of Nov 23 to
the queue.

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------


Neil Conway wrote:
> This patch fixes two tiny memory leaks in pg_dump.
> 
> Cheers,
> 
> Neil
> -- 
> Neil Conway <neilc(at)samurai(dot)com> || PGP Key ID: DB3C29FC
> 
> 

[ text/x-patch is unsupported, treating like TEXT/PLAIN ]

> Index: src/bin/pg_dump/pg_dump.c
> ===================================================================
> RCS file: /var/lib/cvs/pgsql-server/src/bin/pg_dump/pg_dump.c,v
> retrieving revision 1.308
> diff -c -r1.308 pg_dump.c
> *** src/bin/pg_dump/pg_dump.c	23 Nov 2002 03:59:08 -0000	1.308
> --- src/bin/pg_dump/pg_dump.c	27 Nov 2002 21:37:06 -0000
> ***************
> *** 3226,3231 ****
> --- 3226,3232 ----
>   					  "WHERE contypid = '%s'::pg_catalog.oid",
>   					  tinfo->oid);
>   
> + 	PQclear(res);
>   	res = PQexec(g_conn, chkquery->data);
>   	if (!res ||
>   		PQresultStatus(res) != PGRES_TUPLES_OK)
> ***************
> *** 3269,3274 ****
> --- 3270,3276 ----
>   	destroyPQExpBuffer(q);
>   	destroyPQExpBuffer(delq);
>   	destroyPQExpBuffer(query);
> + 	destroyPQExpBuffer(chkquery);
>   }
>   
>   /*

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Neil ConwayDate: 2002-11-27 22:58:48
Subject: Re: fix memory leaks in pg_dump
Previous:From: Neil ConwayDate: 2002-11-27 22:15:18
Subject: fix memory leaks in pg_dump

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group