Skip site navigation (1) Skip section navigation (2)

Re: SRF memory mgmt patch

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: mail(at)joeconway(dot)com, pgsql-patches(at)postgresql(dot)org
Subject: Re: SRF memory mgmt patch
Date: 2002-08-30 01:25:48
Message-ID: 20020830.102548.26275686.t-ishii@sra.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
> Joe Conway <mail(at)joeconway(dot)com> writes:
> > Here's a patch to address Tom's SRF API memory management concerns, as 
> > discussed earlier today on HACKERS.
> 
> Patch committed.
> 
> It seemed to me that pgstattuple.c does not really want to be an SRF,
> but only a function returning a single tuple.

Thank you for modifying pgstattuple.c. You are right, it does not want
to return more than 1 tuple.

> As such, it can provide
> a fine example of using the funcapi.h tuple-building machinery *without*
> the SRF machinery.  I changed it accordingly, but am not able to update
> README.pgstattuple.euc_jp; Tatsuo-san, would you handle that?

Sure. I'll take care of that.
--
Tatsuo Ishii

In response to

Responses

pgsql-hackers by date

Next:From: D'Arcy J.M. CainDate: 2002-08-30 01:28:08
Subject: Re: Type definition process (was Re: MemoryContextAlloc: invalid request size 1934906735)
Previous:From: Bruce MomjianDate: 2002-08-30 01:20:14
Subject: Re: tweaking MemSet() performance

pgsql-patches by date

Next:From: Joe ConwayDate: 2002-08-30 01:29:45
Subject: Re: SRF memory mgmt patch
Previous:From: Tom LaneDate: 2002-08-30 00:46:24
Subject: Re: SRF memory mgmt patch (was [HACKERS] Concern about memory management with SRFs)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group