Re: regression tests for ALTER TABLE ... DEFAULT

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Neil Conway <nconway(at)klamath(dot)dyndns(dot)org>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: regression tests for ALTER TABLE ... DEFAULT
Date: 2002-04-24 04:28:01
Message-ID: 200204240428.g3O4S1203396@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut wrote:
> Bruce Momjian writes:
>
> > Peter Eisentraut wrote:
> > > Neil Conway writes:
> > >
> > > > The attached patch adds regression tests for setting and removing
> > > > default values using ALTER TABLE, on both views and tables.
> > >
> > > Regression tests tend to be more useful if they are added to the list of
> > > tests to run during 'make check'.
> >
> > I am seeing regression failures and am working on those now.
>
> Don't you ever run the tests before checking stuff in?

Nope. I do it once a batch is checked in. I assume submitters have
already done it. Too much work.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-04-24 04:34:26 Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not
Previous Message Peter Eisentraut 2002-04-24 04:10:26 Re: regression tests for ALTER TABLE ... DEFAULT