Skip site navigation (1) Skip section navigation (2)

Re: Patches split from 7.3 queue

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patches split from 7.3 queue
Date: 2002-02-23 20:02:55
Message-ID: 200202232002.g1NK2tf01357@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, I have done my best to split out the accepted patches from the other
> > open items in 7.3.  My logic was to move any patch that generated no
> > negative feedback into the to-be-applied queue at:
> 
> Like Peter, I am *extremely* concerned that you seem to be taking an
> apply-by-default approach to these queued patches.  Most of them have
> not seen any review, and it's unreasonable to expect the reviewers to
> deal with such a huge pile in a short period of time.

I really should have changed that message to 7 days.  Sorry.

What really happened, I think, is with 7.2 in beta, patches didn't get
the full washing they would normally get from the group, so they aren't
as polished as usual.  If we get some feedback to the submitter, we can
just delete them and go back to the normal process of
post/comment/queue.

> At minimum, I want to take an approach of apply-only-after-positive-
> review to these.

OK, shoot over some comments.  Peter already sent over some nice ones.

> > I would like to clean out both of these lists in the next week.
> 
> If you want it done that quickly, then reject 'em all.  We all have
> other tasks besides reviewing.

I can do that.

> I don't normally like being this strict, but because of the unusually
> long beta cycle for 7.2, we have a massive backlog here.  We cannot
> take a business-as-usual approach to dealing with it.

Over one week?  Wow.  Most are jdbc or clear rejections, so once those
are gone, we should be able to deal with these more clearly.  What I
_don't_ want is for this to drag on and on.

If I can not get comments on these within one week, I will apply/reject
them as best I can tell.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2002-02-23 20:21:33
Subject: Re: Patches split from 7.3 queue
Previous:From: Bruce MomjianDate: 2002-02-23 19:36:55
Subject: Re: elog() proposal

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group