Skip site navigation (1) Skip section navigation (2)

Re: Add regression test for ALTER TABLE / ADD UNIQUE

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: pgman(at)candle(dot)pha(dot)pa(dot)us
Cc: chriskl(at)familyhealth(dot)com(dot)au, pgsql-patches(at)postgresql(dot)org
Subject: Re: Add regression test for ALTER TABLE / ADD UNIQUE
Date: 2001-10-31 05:20:57
Message-ID: 200110310520.f9V5KvR21118@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch applied.

---------------------------------------------------------------------------

> > OK,
> > 
> > I've attached a patch that adds some regression tests for alter table / add 
> > unique.
> > 
> > One thing that I don't understand tho, is why when adding a unique 
> > constraint, the notice you receive refers to ALTER TABLE/UNIQUE, where in my 
> > code it has ALTER TABLE/ADD UNIQUE - I don't understand...
> 
> The cause is that the message is coming from parser/analyze.c rather
> than commands/command.c.  You are right to be concerned about the
> consistent wording and spacing because there are multiple words on each
> side of the slash so you really need the spaces for added visibility:
> 
> 	ALTER TABLE / ADD UNIQUE
> 
> > I've only had the chance to test this test suite on my own machine, so you 
> > may wish to test it elsewhere before committing it.
> > 
> > It includes tests for multi-column indices and indices over oid columns.
> 
> I would like to apply the following patch to make your patch show ADD
> UNIQUE instead of just UNIQUE and add spacing around the slash in a few
> cases that were inconsistent.
> 
> The only question I have is how to handle backend/po files.  I can
> easily add the spaces to match the new format if that is OK with the po
> maintainers. 
> 
> I will hold your patch and mine in the queue to see if people have
> comments on this and apply accordingly.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-10-31 05:21:07
Subject: Re: Add regression test for ALTER TABLE / ADD UNIQUE
Previous:From: Bruce MomjianDate: 2001-10-31 05:20:21
Subject: Re: Add regression test for ALTER TABLE / ADD UNIQUE

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group