Re: Add regression test for ALTER TABLE / ADD UNIQUE

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Serguei Mokhov <sa_mokho(at)alcor(dot)concordia(dot)ca>
Cc: chriskl(at)familyhealth(dot)com(dot)au, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Add regression test for ALTER TABLE / ADD UNIQUE
Date: 2001-10-30 20:51:49
Message-ID: 200110302051.f9UKpnB12685@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

> ----- Original Message -----
> From: Serguei Mokhov <sa_mokho(at)alcor(dot)concordia(dot)ca>
> Sent: Monday, October 29, 2001 6:09 PM
>
> > ----- Original Message -----
> > From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
> > Date: Mon, 29 Oct 2001 13:31:44 -0500 (EST)
> >
> > > I would like to apply the following patch to make your patch show ADD
> > > UNIQUE instead of just UNIQUE and add spacing around the slash in a few
> > > cases that were inconsistent.
> >
> > Bruce, you've gone only half way through adding spaces.
> > Attached patch fixes few more of those.
>
> I just realized... Please, don't apply this patch without
> appropriate changes to the expected results of the regression tests!

Yes, of course. I will check regression output before committing.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-10-30 20:52:01 Re: Add regression test for ALTER TABLE / ADD UNIQUE
Previous Message Serguei Mokhov 2001-10-30 17:21:13 Re: Add regression test for ALTER TABLE / ADD UNIQUE