Skip site navigation (1) Skip section navigation (2)

Re: Clear out the reminants of EXTEND INDEX

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Clear out the reminants of EXTEND INDEX
Date: 2001-07-16 19:16:29
Message-ID: 200107161916.f6GJGTw28387@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I always rip that stuff out. We do an initdb for every release.  What
> > could break by renumbering those nodes? 
> 
> Actually, since we don't store node type numbers on disk (just symbolic
> names), there's probably nothing that could break as long as people do a
> full recompile when they update.  It's no worse than changing the fields
> of a widely-used struct, I suppose.  I was just being paranoid.
> 
> If you want to apply the patch as-is then you might as well remove all
> the "XXX"'d items in nodes.h...

OK, patch applied, and I applied the following additional patch to
remove two XXX entries in nodes.h.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2001-07-16 19:30:27
Subject: Re: Clear out the reminants of EXTEND INDEX
Previous:From: Tom LaneDate: 2001-07-16 18:55:31
Subject: Re: Clear out the reminants of EXTEND INDEX

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group