> I apologize for not having noticed your patch before I committed
> what I was doing; the conflict is my fault. If you have time to redo
> your changes atop mine, it would be appreciated. Otherwise I'll take
> responsibility for cleaning up the mess.
> BTW, I would recommend that you not add logic to suppress the assignment
> when the value is not changing. Now that there are assign_hooks for all
> variable types, it seems to me that it is the assign_hook's
> responsibility to decide whether it wants to optimize that case or not.
This assume the assign hooks have no negative effects. Should we call
them if the value isn't changed?
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
In response to
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2001-06-13 15:45:35|
|Subject: Re: reset all update |
|Previous:||From: Bruce Momjian||Date: 2001-06-13 15:33:47|
|Subject: Re: Patch to include PAM support...|