Skip site navigation (1) Skip section navigation (2)

Re: YA readline 4.2 patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Pgsql-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: YA readline 4.2 patch
Date: 2001-06-11 22:13:03
Message-ID: 200106112213.f5BMD3i18539@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Patch applied and autoconf run.

> The attached patch enables PostgreSQL CVS to build cleanly under Cygwin
> when built against readline 4.2.  Specifically, it handles the deprecation
> of
>     
>     filename_completion_function()
>     
> with preference for
> 
>     rl_filename_completion_function()
> 
> Although, I was motivated by Cygwin support, IMO this patch is appropriate
> for all platforms.  To quote from the readline source:
> 
>     #if 0
>     /* Backwards compatibility (compat.c).  These will go away sometime. */
>     ...
>     extern READLINE_EXPORT(char, *filename_completion_function) ...
>     #endif
> 
> Note that this patch is modeled after the one by Peter Eisentraut for
> completion_matches():
> 
>     http://www.ca.postgresql.org/~petere/readline42.html
> 
> I tested this patch under the following environments:
> 
>     Cygwin with readline 4.1
>     Cygwin with readline 4.2
>     Linux with readline 2.2.1
>     Linux with readline 4.2
> 
> and it behaved as expected.
> 
> Thanks,
> Jason
> 
> -- 
> Jason Tishler
> Director, Software Engineering       Phone: 732.264.8770 x235
> Dot Hill Systems Corp.               Fax:   732.264.8798
> 82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
> Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo(at)postgresql(dot)org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-06-11 22:19:30
Subject: Re: take 2: show all / reset all
Previous:From: Bruce MomjianDate: 2001-06-11 16:44:40
Subject: Re: reset all update

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group