Skip site navigation (1) Skip section navigation (2)

Re: [PORTS] Re: patch for minor Win32 makefile bug

From: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fred Yankowski <fred(at)ontosys(dot)com>, pgsql-patches(at)postgresql(dot)org, pgsql-ports(at)postgresql(dot)org
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Date: 2001-04-04 19:52:33
Message-ID: 20010404155233.A63@dothill.com (view raw or flat)
Thread:
Lists: pgsql-patchespgsql-ports
Peter,

On Wed, Apr 04, 2001 at 09:51:53PM +0200, Peter Eisentraut wrote:
> Tom Lane writes:
> 
> > Works for me.  Given that we'd like to package RC3 tonight, it'd be nice
> > to get this done ASAP.  Do you have time to work up and test a patch
> > today, or shall I risk making untested changes myself?
> 
> AFAIU, this doesn't actually fix a problem, it only cleans up a
> long-standing oddity.  So why the rush?

I don't know if this is a problem or not, but Tom had already
checked in a different patch that removed the DLLLIBS definition
from src/backend/Makefile.  Hence, when the backend is built it will
try to link with itself.  This is due to the DLLLIBS definition in
src/makefiles/Makefile.win no longer being overriden by the one in
src/backend/Makefile.  May be this is a no-op.  I don't know.

Nevertheless, I have generated, tested, and submitted my updated patch.

Jason

-- 
Jason Tishler
Director, Software Engineering       Phone: +1 (732) 264-8770 x235
Dot Hill Systems Corp.               Fax:   +1 (732) 264-8798
82 Bethany Road, Suite 7             Email: Jason(dot)Tishler(at)dothill(dot)com
Hazlet, NJ 07730 USA                 WWW:   http://www.dothill.com

In response to

pgsql-ports by date

Next:From: Peter EisentrautDate: 2001-04-04 19:53:08
Subject: Re: PostgreSQL and Microsoft Visual C
Previous:From: Peter EisentrautDate: 2001-04-04 19:51:53
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug

pgsql-patches by date

Next:From: Tom LaneDate: 2001-04-04 20:15:07
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug
Previous:From: Peter EisentrautDate: 2001-04-04 19:51:53
Subject: Re: [PORTS] Re: patch for minor Win32 makefile bug

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group