Skip site navigation (1) Skip section navigation (2)

Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marcin Kowalski <kowalski(at)datrix(dot)co(dot)za>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Date: 2001-04-01 00:58:17
Message-ID: 200104010058.TAA21172@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-adminpgsql-bugspgsql-generalpgsql-hackerspgsql-sql
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > First, here is a patch which will prevent this from happening in the
> > future.  Do people want this held for 7.2 or applied now?  It disables
> > the creation of user indexes on system tables.
>   
> > + 	if (heapRelationName && !allow_system_table_mods &&
> > + 		IsSystemRelationName(heapRelationName) && IsNormalProcessingMode())
> > + 	{
> > + 		elog(ERROR, "You can not create indexes on system tables:  '%s'",
> > + 			 heapRelationName);
> > + 	}
> > + 
> 
> I think it would be a real good idea to put in this safeguard, but
> I don't much like that error message.  How about
> 
>     elog(ERROR, "User-defined indexes on system catalogs are not supported");

Change made to patch.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2001-04-01 01:02:25
Subject: Re: Re: Changing the default value of an inherited column
Previous:From: Tom LaneDate: 2001-04-01 00:53:39
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

pgsql-sql by date

Next:From: Stef TelfordDate: 2001-04-01 07:50:20
Subject: Trigger Function and Html Output
Previous:From: Tom LaneDate: 2001-04-01 00:53:39
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

pgsql-admin by date

Next:From: Yasuo OhgakiDate: 2001-04-01 09:05:24
Subject: libpq bug? (I guess not)
Previous:From: Tom LaneDate: 2001-04-01 00:53:39
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

pgsql-bugs by date

Next:From: Tom LaneDate: 2001-04-01 01:09:03
Subject: Re: segmentation fault in psql
Previous:From: Tom LaneDate: 2001-04-01 00:53:39
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

pgsql-general by date

Next:From: JacobDate: 2001-04-01 02:11:39
Subject: SELECT MAX question
Previous:From: Tom LaneDate: 2001-04-01 00:57:59
Subject: Re: dynamic field names in a function.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group