Skip site navigation (1) Skip section navigation (2)

Re: Small xlog.c cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Matthew Kirkwood <matthew(at)hairy(dot)beasts(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Small xlog.c cleanup
Date: 2001-02-27 20:55:21
Message-ID: 200102272055.PAA06622@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
> On Tue, 27 Feb 2001, Tom Lane wrote:
> 
> > The Hermit Hacker <scrappy(at)hub(dot)org> writes:
> > > He's moved the "static globals" from around line 286 of
> > > src/backend/access/transam/xlog.c:
> > > to be static locals inside of function ReadRecord around line 1216 in the
> > > same file:
> >
> > This is not usual coding practice in Postgres, so far as I've noticed.
> >
> > I prefer to avoid static locals because the fact that they *are* static
> > is easily missed.  In particular it's way too easy to misread the
> > initialization as something that happens on every entry to the function,
> > rather than only once.  So my opinion is that this change is bad style.
> 
> Oops, don't take my response to Bruce as validation, only explanation of
> what he was accomplishing, which Bruce appeared to indicate he didn't
> understand ...

Thanks.  I was looking for 'static/no static' but now replace we was
moving the defines, which makes them behave differently.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Matthew KirkwoodDate: 2001-02-27 21:12:41
Subject: Re: Small xlog.c cleanup
Previous:From: The Hermit HackerDate: 2001-02-27 19:10:07
Subject: Re: Small xlog.c cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group