Re: Re: Cygwin PostgreSQL CVS Patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Jason Tishler <Jason(dot)Tishler(at)dothill(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-ports(at)postgresql(dot)org
Subject: Re: Re: Cygwin PostgreSQL CVS Patch
Date: 2001-01-17 22:08:18
Message-ID: 200101172208.RAA11171@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-ports

Can someone tell me the status of this patch?

> Peter,
>
> On Sat, Jan 13, 2001 at 04:37:31AM +0100, Peter Eisentraut wrote:
> > Jason Tishler writes:
> >
> > > > Okay, so we could change the regression test driver to set a PATH that
> > > > includes libdir. No problem there.
> > >
> > > See attached patch for the above.
> >
> > Installed.
>
> Thanks. I meant to surround the Cygwin specific stuff with a case
> statement but forgot -- thanks for cleaning up after me. Sigh...
>
> > Another issue you might be interested in is that of Unix domain sockets.
> > I understand that they now exist in Cygwin, so you might want to refine
> > this snippet in src/include/config.h[.in]:
> >
> > /*
> > * Define this if your operating system supports AF_UNIX family sockets.
> > */
> > #if !defined(__CYGWIN__) && !defined(__QNX__) && !defined(__BEOS__)
> > # define HAVE_UNIX_SOCKETS 1
> > #endif
> >
> > And take a look at doc/FAQ_MSWIN, if you like, to see if it's up to date.
>
> See attached patch and ChangeLog. This trivial patch enables UNIX
> domain sockets for Cygwin. This version of Cygwin PostgreSQL still
> passes all regression tests. However, there are two issues with
> Cygwin's support of UNIX domain sockets:
>
> 1. psql (and other clients) with hang if postmaster is not running
> and the socket file (e.g., /tmp/.s.PGSQL.5432) exists
> 2. Cygwin's AF_UNIX sockets are really implemented as AF_INET
> sockets so they are inherently insecure. See the follow for more
> details:
>
> http://sources.redhat.com/ml/cygwin/2000-12/msg01058.html
>
> The procedure to apply the patch is as follows:
>
> $ cd pgsql
> $ # save attached patch to current directory
> $ patch -p0 <af_unix.patch
>
> Thanks,
> Jason
>
> --
> Jason Tishler
> Director, Software Engineering Phone: +1 (732) 264-8770 x235
> Dot Hill Systems Corp. Fax: +1 (732) 264-8798
> 82 Bethany Road, Suite 7 Email: Jason(dot)Tishler(at)dothill(dot)com
> Hazlet, NJ 07730 USA WWW: http://www.dothill.com

[ Attachment, skipping... ]

[ Attachment, skipping... ]

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-ports by date

  From Date Subject
Next Message bart sikkes 2001-01-18 00:35:36 compile problem on a vax
Previous Message Jason Tishler 2001-01-17 19:46:04 Re: PostGreSQL on Windows Help