Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] xlog.c.patch for cygwin port.

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: jay(at)sprucegrove(dot)com
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] xlog.c.patch for cygwin port.
Date: 2000-03-08 03:03:11
Message-ID: 20000308120311P.t-ishii@sra.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
> >> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> > This looks interesting.  We could remove some of our ifwin cruft.
> >> 
> >> I have been thinking for quite some time that most of the CYGWIN32
> >> ifdefs represent very poor programming.  Instead of zillions of
> >> 
> >> #ifndef __CYGWIN32__
> >> 	fd = open(filename, O_RDONLY, 0666);
> >> #else
> >> 	fd = open(filename, O_RDONLY | O_BINARY, 0666);
> >> #endif
> >> 
> >> we should have in one include file something like
> >
> >Do we ever assign a function pointer for open() anywhere.  If so, the
> >define will not work without some kind of wrapper, right?
> 
> Since the only difference seems to be "O_RDONLY" vs "O_RDONLY | O_BINARY",
> why not do the #define on that?
> 
> At least in this case it works.

BTW, why do we call open() directory here? Why not VFD interface?
--
Tatsuo Ishii

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2000-03-08 04:53:53
Subject: Re: [HACKERS] DROP TABLE inside a transaction block
Previous:From: Lamar OwenDate: 2000-03-08 02:57:36
Subject: Re: [HACKERS] DROP TABLE inside a transaction block

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group