Re: [HACKERS] freefuncs.c is never called from anywhere!?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, The Hermit Hacker <scrappy(at)hub(dot)org>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] freefuncs.c is never called from anywhere!?
Date: 2000-02-01 01:58:27
Message-ID: 200002010158.UAA21631@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I think it would be a bad idea to go around and yank out NOT_USED code
> wholesale --- this should be looked at on a case-by-case basis, with
> consideration of whether the code might be useful again in future.
>
> But I think I might vote for pruning the _deadcode directories
> wholesale. I suspect the files in them are suffering from
> irrecoverable bit rot.

I disagree on _deadcode. While the code is rotted, it does implement
some full functions that have no other history, like verion.c for
versioning and xfunc for expensive functions. Yanking them means we can
never know what they did.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-02-01 02:02:30 Re: [HACKERS] Another nasty cache problem
Previous Message Bruce Momjian 2000-02-01 01:55:53 Re: [HACKERS] Re: Case-folding bogosity in new psql