Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] PL patches

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: brook(at)trillium(dot)NMSU(dot)Edu (Brook Milligan)
Cc: hackers(at)postgreSQL(dot)org, patches(at)postgreSQL(dot)org
Subject: Re: [PATCHES] PL patches
Date: 1998-10-08 23:45:28
Message-ID: 199810082345.TAA29937@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Applied, and Makefile.in added.

> I have had a few problems with the PL stuff recently committed.  The
> following patches fix the problems (i.e., all regression tests pass)
> in what I hope to be a platform-independent fashion.  The accomplish
> the following:
> 
> 1.  Allow configure to check for the existence of the tclConfig.sh
>     script needed to configure the tcl component of PL.  Configure
>     already checks other parts of the tcl installation, so it might
>     as well check for this script, too, so that paths need not be
>     hard-coded into mkMakefile.tcldefs.
> 
>     A few extra files are created by configure from templates.
> 
>     Configure is also cleaned up a bit at the end so the long list of
>     output files is easier to deal with.
> 
> NOTE:  run autoconf.
> 
> 2.  A new script mkMakefile.tcldefs.sh is created from the template
>     mkMakefile.tcldefs.sh.in so that the substitution for tclConfig.sh
>     can be inserted.  The script is simplified and renamed to reflect
>     the fact that it is a sh script.
> 
> NOTE:  pl/tcl/mkMakefile.tcldefs should be removed from the tree.
> 
> 3.  The Makefile executes /bin/sh on the new script rather than
>     directly executing the script (hence the name change to make it
>     more explicit).
> 
> 4.  There are shared library problems with the plpgsql/src/Makefile.
>     The port-specific code was taken from the interfaces/tcl?/Makefile
>     so that shared libraries should work on all platforms.  This means 
>     that that Makefile must be a template for configure.
> 
> NOTE:  pl/plpgsql/src/Makefile should be removed from the tree.
> 
> NOTE:  should we be including libtool in our distribution to simplify
> shared library (and other stuff) support?
> 
> Cheers,
> Brook


-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist(at)candle(dot)pha(dot)pa(dot)us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026


In response to

  • PL patches at 1998-10-08 17:27:22 from Brook Milligan

pgsql-hackers by date

Next:From: Bruce MomjianDate: 1998-10-09 00:42:31
Subject: more static/NOT_USED functions
Previous:From: Tom LaneDate: 1998-10-08 22:40:20
Subject: Re: [HACKERS] PL patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group