Re: [HACKERS] SunOS patches

From: t-ishii(at)sra(dot)co(dot)jp
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: t-ishii(at)sra(dot)co(dot)jp, PostgreSQL HACKERS <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [HACKERS] SunOS patches
Date: 1998-03-02 03:21:26
Message-ID: 199803020321.MAA04401@srapc451.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> ----------------------------------------------------------------------
>> *** backend/libpq/pqcomm.c.orig Fri Feb 27 14:07:52 1998
>> --- backend/libpq/pqcomm.c Fri Feb 27 14:08:50 1998
>> ***************
>> *** 564,571 ****
>> * Shutdown routine for backend connection
>> * If a Unix socket is used for communication, explicitly close it.
>> */
>> ! static void
>> ! do_unlink()
>> {
>> if (sock_path[0])
>> unlink(sock_path);
>> --- 564,571 ----
>> * Shutdown routine for backend connection
>> * If a Unix socket is used for communication, explicitly close it.
>> */
>> ! void
>> ! StreamDoUnlink()
>
>
> What breaks by renaming this function?? :(

Nothing. do_unlink() is called only from line 648 and the line was
deleted by my patches.
Just removing "static" from the declaration of do_unlink might be ok.
However function name "do_unlink" would be too general IMHO.
--
Tatsuo Ishii
t-ishii(at)sra(dot)co(dot)jp

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas G. Lockhart 1998-03-02 03:23:51 Re: [HACKERS] SunOS patches
Previous Message The Hermit Hacker 1998-03-02 03:05:56 Re: [HACKERS] SunOS patches