Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Disallow changing/dropping default expression

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Disallow changing/dropping default expression
Date: 2006-06-27 15:15:47
Message-ID: 19931.1151421347@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Wasn't this patch rejected?

> Anyway, what is your opinion on this?

I thought we'd rejected it.  I'm not sure that we'd completely agreed
what the best thing to do is, but what this patch actually does is to
silently remove the dependency link.  That is, after

	create table t1 (f1 serial);
	alter table t1 alter column f1 drop default;

t1_f1_seq is still there, but now completely unconnected to t1.
That doesn't seem to me to satisfy the principle of least surprise.
It's certainly not what the TODO item says (reject the DROP DEFAULT).
I think we were considering the alternative of having the DROP DEFAULT
remove the sequence, which probably could be implemented painlessly
with a change in the way we set up the dependency links to start with.

In any case I don't like this patch: int/bool confusion, use of elog
instead of ereport for a user-facing error message, failure to adhere to
style guidelines for that message, etc.  (Although seeing that the error
message is unreachable code, maybe that doesn't matter ;-))  Aside from
the poor coding style, the whole idea of reaching into pg_depend to
remove a single dependency strikes me as a brute-force solution to
a problem that should have a more elegant answer.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Yoshiyuki AsabaDate: 2006-06-27 15:23:13
Subject: SO_SNDBUF size is small on win32?
Previous:From: Martijn van OosterhoutDate: 2006-06-27 14:20:41
Subject: Re: vacuum, performance, and MVCC

pgsql-committers by date

Next:From: Alvaro HerreraDate: 2006-06-27 15:20:11
Subject: Re: pgsql: Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table
Previous:From: Tom LaneDate: 2006-06-27 14:01:42
Subject: pgsql: Fix typo.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group